Up retry for ETXTBSY #60741
Merged
Up retry for ETXTBSY #60741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still seeing occasional failure in Alpine (https://dev.azure.com/dnceng/public/_build/results?buildId=1434759) so raising the retry time.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Member
Author
|
ping @VSadov for review |
VSadov
reviewed
Oct 25, 2021
| // 10 ms is short, but the race we're trying to avoid is in-between | ||
| // "fork" and "exec", so it should be fast | ||
| Thread.Sleep(10); | ||
| Thread.Sleep(50); |
Member
There was a problem hiding this comment.
Now if we wait, we would wait at least 50ms. I think something like Sleep(i * 20) and limiting i < 4 could have better balance between common quick case and if needed a longer wait.
The nice part is that the fist iteration would be Sleep(0), which works like a machine-wide Yield, but without minimum wait.
VSadov
approved these changes
Oct 26, 2021
Member
VSadov
left a comment
VSadov
left a comment
There was a problem hiding this comment.
LGTM, but I think scaling the back-off wait would allow us to wait longer in rare unfortunate cases and thus reduce chances that we will need to look at this again.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still seeing occasional failure in Alpine
(https://dev.azure.com/dnceng/public/_build/results?buildId=1434759) so
raising the retry time.